Fixed filtering of bokeh LineAnnotationPlot properties #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, happy to merge once the tests pass. |
|
Will have to add a dask 0.14 compatibility PR because they changed a bit of API, hopefully they can restore the correct behavior in 0.14.1. |
|
Have you filled an issue for dask pointing out the breaking change? |
philippjfr
force-pushed
the
vline_filter_props
branch
from
dddaf2d
to
eff5253
Compare
Pinged the person responsibly after asking Matt about it. Temporarily pinned dask now. Once I've heard back we'll have to decide what to do. |
That means I can merge once the tests pass, right? |
Yes. |
|
Great! The pr build has now passed and the push build will fail due to a transient. I don't see any reason to bother restarting the push build. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor self-explanatory fix.